[Mlir-commits] [mlir] Fix late comment review for #102038 (PR #102869)

Giuseppe Rossini llvmlistbot at llvm.org
Mon Aug 12 02:41:04 PDT 2024


https://github.com/giuseros created https://github.com/llvm/llvm-project/pull/102869

None

>From b908af45ed8c3018f1e6784cedf169785200a63d Mon Sep 17 00:00:00 2001
From: Giuseppe Rossini <giuseppe.rossini at amd.com>
Date: Mon, 12 Aug 2024 10:04:51 +0100
Subject: [PATCH] Fix late comment review for #102038

---
 mlir/lib/Transforms/Utils/RegionUtils.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mlir/lib/Transforms/Utils/RegionUtils.cpp b/mlir/lib/Transforms/Utils/RegionUtils.cpp
index dd75e283a36b8d..3c7523827699c8 100644
--- a/mlir/lib/Transforms/Utils/RegionUtils.cpp
+++ b/mlir/lib/Transforms/Utils/RegionUtils.cpp
@@ -1012,7 +1012,8 @@ static LogicalResult dropRedundantArguments(RewriterBase &rewriter,
 
     // Add any nested regions to the worklist.
     for (Block &block : *region) {
-      anyChanged = succeeded(dropRedundantArguments(rewriter, block));
+      anyChanged =
+          succeeded(dropRedundantArguments(rewriter, block)) || anyChanged;
 
       for (Operation &op : block)
         for (Region &nestedRegion : op.getRegions())



More information about the Mlir-commits mailing list