[Mlir-commits] [mlir] [mlir][linalg] Fix isaConvolutionOpInterface logic (PR #102087)

Quinn Dawkins llvmlistbot at llvm.org
Wed Aug 7 07:09:02 PDT 2024


qedawkins wrote:

> Some testing would be nice, but that would have to be a unit test and there's just none for Linalg atm :( I'm leaving that as a nice-to-have.

I was trying to think about what kind of test could be added, but this is pretty much just exposing an option that was already there. If we wanted to make it essentially NFC we could change the default back. We could also add a transform dialect op for `isaConvolutionOpInterface`, but I have the same thinking as you about nice-to-have.

https://github.com/llvm/llvm-project/pull/102087


More information about the Mlir-commits mailing list