[Mlir-commits] [mlir] [mlir][linalg] Fix isaConvolutionOpInterface logic (PR #102087)

Andrzej Warzyński llvmlistbot at llvm.org
Wed Aug 7 07:01:51 PDT 2024


banach-space wrote:

> Thanks, can you change the PR title to something more descriptive like
> 
> ```
> [mlir][linalg] Exclude non-convolutional ops from isaConvolutionOpInterface
> ```
> 
> like @banach-space was looking for?

Thanks, that's exactly what I was after 🙏🏻 

Some testing would be nice, but that would have to be a unit test and there's just none for Linalg atm :( I'm leaving that as a nice-to-have.

This change makes sense to :)

https://github.com/llvm/llvm-project/pull/102087


More information about the Mlir-commits mailing list