[Mlir-commits] [mlir] [mlir][Vector] Make `vector.contract` work with scalable vectors (PR #65724)

[Cullen Rhodes]

c-rhodes wrote:

> Thanks for taking a look!
> 
> > LGTM at a glance but I wonder if it's worth adding integration tests? Perhaps copying `mlir/test/Integration/Dialect/Vector/CPU/test-contraction.mlir` for `mlir/test/Integration/Dialect/Vector/CPU/ArmSVE/test-contraction.mlir`?
> 
> Big +1 :)
> 
> However, I'm discovering quite a few subtle bits like this one while integrating things in IREE. Mindful that `vector.contract` is rather complex, I prefer doing this incrementally. But yes, we should be adding integration tests for `vector.contract` for SVE ASAP.

Ok that's fine but please update the title of the commit / pull request to clarify this is simply fixing scalable dims being dropped in vector.contract lowering, because it currently implies the scope is grander than it is, and like you say this is a complex op so I doubt scalable vector support ends here?

https://github.com/llvm/llvm-project/pull/65724