[Mlir-commits] [mlir] [mlir][Vector] Make `vector.contract` work with scalable vectors (PR #65724)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Fri Sep 8 02:54:02 PDT 2023
banach-space wrote:
> LGTM at a glance but I wonder if it's worth adding integration tests? Perhaps copying `mlir/test/Integration/Dialect/Vector/CPU/test-contraction.mlir` for `mlir/test/Integration/Dialect/Vector/CPU/ArmSVE/test-contraction.mlir`?
Big +1 :) However, I'm discovering quite a few subtle bits like this one while integrating things in IREE. Mindful that `vector.contract` is rather complex, I prefer doing this incrementally. But yes, we should be adding integration tests for `vector.contract` for SVE ASAP.
https://github.com/llvm/llvm-project/pull/65724
More information about the Mlir-commits
mailing list