[Mlir-commits] [mlir] [mlir] reword error message on unloaded dialect (PR #67980)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Mon Oct 2 05:44:13 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-core
<details>
<summary>Changes</summary>
The previous message was confusing as it mentioned "registration" but isn't in fact related to dialect registration. Use other words instead.
---
Full diff: https://github.com/llvm/llvm-project/pull/67980.diff
1 Files Affected:
- (modified) mlir/include/mlir/IR/Builders.h (+2-2)
``````````diff
diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h
index 3eca8bd12f43364..5e54d4ea49e8251 100644
--- a/mlir/include/mlir/IR/Builders.h
+++ b/mlir/include/mlir/IR/Builders.h
@@ -477,8 +477,8 @@ class OpBuilder : public Builder {
if (LLVM_UNLIKELY(!opName)) {
llvm::report_fatal_error(
"Building op `" + OpT::getOperationName() +
- "` but it isn't registered in this MLIRContext: the dialect may not "
- "be loaded or this operation isn't registered by the dialect. See "
+ "` but it isn't known in this MLIRContext: the dialect may not "
+ "be loaded or this operation hasn't been added by the dialect. See "
"also https://mlir.llvm.org/getting_started/Faq/"
"#registered-loaded-dependent-whats-up-with-dialects-management");
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/67980
More information about the Mlir-commits
mailing list