[Mlir-commits] [mlir] [mlir] reword error message on unloaded dialect (PR #67980)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Mon Oct 2 05:43:10 PDT 2023


https://github.com/ftynse created https://github.com/llvm/llvm-project/pull/67980

The previous message was confusing as it mentioned "registration" but isn't in fact related to dialect registration. Use other words instead.

>From acbeb054fa3debf81fabe0a5e002d72a7b408173 Mon Sep 17 00:00:00 2001
From: Alex Zinenko <zinenko at google.com>
Date: Mon, 2 Oct 2023 12:41:51 +0000
Subject: [PATCH] [mlir] reword error message on unloaded dialect

The previous message was confusing as it mentioned "registration" but
isn't in fact related to dialect registration. Use other words instead.
---
 mlir/include/mlir/IR/Builders.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/include/mlir/IR/Builders.h b/mlir/include/mlir/IR/Builders.h
index 3eca8bd12f43364..5e54d4ea49e8251 100644
--- a/mlir/include/mlir/IR/Builders.h
+++ b/mlir/include/mlir/IR/Builders.h
@@ -477,8 +477,8 @@ class OpBuilder : public Builder {
     if (LLVM_UNLIKELY(!opName)) {
       llvm::report_fatal_error(
           "Building op `" + OpT::getOperationName() +
-          "` but it isn't registered in this MLIRContext: the dialect may not "
-          "be loaded or this operation isn't registered by the dialect. See "
+          "` but it isn't known in this MLIRContext: the dialect may not "
+          "be loaded or this operation hasn't been added by the dialect. See "
           "also https://mlir.llvm.org/getting_started/Faq/"
           "#registered-loaded-dependent-whats-up-with-dialects-management");
     }



More information about the Mlir-commits mailing list