[Mlir-commits] [mlir] [mlir][gpu] Introduce `gpu.dynamic_shared_memory` Op (PR #71546)

Mehdi Amini llvmlistbot at llvm.org
Mon Nov 13 08:46:03 PST 2023


================
@@ -32,6 +35,18 @@
 namespace mlir {
 namespace gpu {
 
+/// GPU memory space identifiers.
+enum GPUMemorySpace {
+  /// Generic memory space identifier.
+  kGenericMemorySpace = 0,
+
+  /// Global memory space identifier.
+  kGlobalMemorySpace = 1,
+
+  /// Shared memory space identifier.
+  kSharedMemorySpace = 3
+};
----------------
joker-eph wrote:

I am confused: this Enum seems dead at HEAD? If there are no-uses, you're just introducing new used here.

My comment is really directed at the code you're adding (which justify you're "move" of this enum right now): can this be removed?

https://github.com/llvm/llvm-project/pull/71546


More information about the Mlir-commits mailing list