[Mlir-commits] [mlir] [mlir][gpu] Introduce `gpu.dynamic_shared_memory` Op (PR #71546)

[Guray Ozen]

================
@@ -32,6 +35,18 @@
 namespace mlir {
 namespace gpu {
 
+/// GPU memory space identifiers.
+enum GPUMemorySpace {
+  /// Generic memory space identifier.
+  kGenericMemorySpace = 0,
+
+  /// Global memory space identifier.
+  kGlobalMemorySpace = 1,
+
+  /// Shared memory space identifier.
+  kSharedMemorySpace = 3
----------------
grypp wrote:

I agree that the naming is confusing. The PR only moves this `enum` from `GPUDialect.cpp` to `GPUDialect.h`. 

Also the name of the Op is `gpu.dynamic_shared_memory` and we have `dynamic_shared_memory_size` attribute on `gpu.launch`

I can fix them follow-up pr



https://github.com/llvm/llvm-project/pull/71546