[Mlir-commits] [mlir] [Doc] fix incorrect syntax for gpu.launch (PR #76381)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Dec 25 20:58:31 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: youkaichao (youkaichao)

<details>
<summary>Changes</summary>

Per the code:

https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td#L805

And the usage:

https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp#L869

The keyword should be `blocks` rather than `block`. The documentation of the syntax is out of date.

---
Full diff: https://github.com/llvm/llvm-project/pull/76381.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/GPU/IR/GPUOps.td (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
index b536b6c97cef0d..efef61b5c6e712 100644
--- a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
+++ b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
@@ -713,7 +713,7 @@ def GPU_LaunchOp : GPU_Op<"launch", [
 
     ```
     operation ::= `gpu.launch` (`async` (`[` ssa-id-list `]`)? )?
-                             `block` `(` ssa-id-list `)` `in` ssa-reassignment
+                             `blocks` `(` ssa-id-list `)` `in` ssa-reassignment
                              `threads` `(` ssa-id-list `)` `in` ssa-reassignment
                              (dynamic_shared_memory_size ssa-use)?
                              memory-attribution

``````````

</details>


https://github.com/llvm/llvm-project/pull/76381


More information about the Mlir-commits mailing list