[Mlir-commits] [mlir] [Doc] fix incorrect syntax for gpu.launch (PR #76381)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Mon Dec 25 20:58:05 PST 2023
https://github.com/youkaichao created https://github.com/llvm/llvm-project/pull/76381
Per the code:
https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td#L805
And the usage:
https://github.com/llvm/llvm-project/blob/5c39b8d1a86cc0c92acd438d4799d19e67ae70db/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp#L869
The keyword should be `blocks` rather than `block`. The documentation of the syntax is out of date.
>From 3cfc0b118496b208973093ad6d09d021caebebea Mon Sep 17 00:00:00 2001
From: youkaichao <youkaichao at gmail.com>
Date: Tue, 26 Dec 2023 12:55:51 +0800
Subject: [PATCH] [Doc] fix incorrect syntax
---
mlir/include/mlir/Dialect/GPU/IR/GPUOps.td | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
index b536b6c97cef0d..efef61b5c6e712 100644
--- a/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
+++ b/mlir/include/mlir/Dialect/GPU/IR/GPUOps.td
@@ -713,7 +713,7 @@ def GPU_LaunchOp : GPU_Op<"launch", [
```
operation ::= `gpu.launch` (`async` (`[` ssa-id-list `]`)? )?
- `block` `(` ssa-id-list `)` `in` ssa-reassignment
+ `blocks` `(` ssa-id-list `)` `in` ssa-reassignment
`threads` `(` ssa-id-list `)` `in` ssa-reassignment
(dynamic_shared_memory_size ssa-use)?
memory-attribution
More information about the Mlir-commits
mailing list