[Mlir-commits] [mlir] [mlir][SCF] Remove unused `fail_if_already_divisible` from the .td file (PR #76074)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-scf

Author: Pablo Antonio Martinez (pabloantoniom)

<details>
<summary>Changes</summary>

Unless I'm missing something, the `fail_if_already_divisible` attribute in the `LoopPeelOp` is doing nothing. It seems like the logic was removed in 5230710, but the option was not removed in the .td file. This is confusing because users (e.g.: myself a few days ago) may think that this is doing something while actually it does nothing.

---
Full diff: https://github.com/llvm/llvm-project/pull/76074.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td (+1-2) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td b/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
index b5ac22a2a758dd..7bde9784c0314b 100644
--- a/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
+++ b/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
@@ -139,8 +139,7 @@ def LoopPeelOp : Op<Transform_Dialect, "loop.peel",
 
   let arguments =
       (ins Transform_ScfForOp:$target,
-           DefaultValuedAttr<BoolAttr, "false">:$peel_front,
-           DefaultValuedAttr<BoolAttr, "false">:$fail_if_already_divisible);
+           DefaultValuedAttr<BoolAttr, "false">:$peel_front);
   let results = (outs TransformHandleTypeInterface:$peeled_loop,
                       TransformHandleTypeInterface:$remainder_loop);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/76074