[Mlir-commits] [mlir] [mlir][SCF] Remove unused `fail_if_already_divisible` from the .td file (PR #76074)

[Pablo Antonio Martinez]

https://github.com/pabloantoniom created https://github.com/llvm/llvm-project/pull/76074

Unless I'm missing something, the `fail_if_already_divisible` attribute in the `LoopPeelOp` is doing nothing. It seems like the logic was removed in 5230710, but the option was not removed in the .td file. This is confusing because users (e.g.: myself a few days ago) may think that this is doing something while actually it does nothing.

>From 1c8ba6041b35055cbfd07646be94e9b7368a0f87 Mon Sep 17 00:00:00 2001
From: Pablo Antonio Martinez <pablo.antonio.martinez at huawei.com>
Date: Wed, 20 Dec 2023 16:26:04 +0000
Subject: [PATCH] [mlir][SCF] Remove unused fail_if_already_divisible

---
 mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td b/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
index b5ac22a2a758dd..7bde9784c0314b 100644
--- a/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
+++ b/mlir/include/mlir/Dialect/SCF/TransformOps/SCFTransformOps.td
@@ -139,8 +139,7 @@ def LoopPeelOp : Op<Transform_Dialect, "loop.peel",
 
   let arguments =
       (ins Transform_ScfForOp:$target,
-           DefaultValuedAttr<BoolAttr, "false">:$peel_front,
-           DefaultValuedAttr<BoolAttr, "false">:$fail_if_already_divisible);
+           DefaultValuedAttr<BoolAttr, "false">:$peel_front);
   let results = (outs TransformHandleTypeInterface:$peeled_loop,
                       TransformHandleTypeInterface:$remainder_loop);