[Mlir-commits] [mlir] Revert "[mlir] Fix a warning" (PR #73640)

[Mehdi Amini]

joker-eph wrote:

> mlir/lib/Pass/PassRegistry.cpp:376:37: error: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Werror,-Wdtor-name]


Which compiler complains about this and do we understand why? The message isn't clear to me?

> Does this mean we need to check the C++ version like so?
>
> #if __cplusplus >= 202002L
> llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
> #else
> llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
> #endif

That could be an option, but to me this is only valid if we can point to the change in the standard that justifies this.

https://github.com/llvm/llvm-project/pull/73640