[Mlir-commits] [mlir] Revert "[mlir] Fix a warning" (PR #73640)

[Kazu Hirata]

kazutakahirata wrote:

Sorry for the slow response here.  If we simply revert the patch, we would get the same warning as before:

```
mlir/lib/Pass/PassRegistry.cpp:376:37: error: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Werror,-Wdtor-name]
```

Does this mean we need to check the C++ version like so?

```
#if __cplusplus >= 202002L
llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
#else
llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
#endif
```


https://github.com/llvm/llvm-project/pull/73640