[Mlir-commits] [mlir] [MLIR][LLVM] Remove typed pointers from the LLVM dialect (PR #71285)
Mehdi Amini
llvmlistbot at llvm.org
Tue Dec 5 18:28:39 PST 2023
================
@@ -445,7 +414,7 @@ def LLVM_StoreOp : LLVM_MemAccessOpBase<"store",
let assemblyFormat = [{
(`volatile` $volatile_^)? $value `,` $addr
(`atomic` (`syncscope` `(` $syncscope^ `)`)? $ordering^)?
- attr-dict `:` custom<StoreType>(type($value), type($addr))
+ attr-dict `:` type($value) `,` qualified(type($addr))
----------------
joker-eph wrote:
Of course! But the answer is contextual...
For example it's not obvious to me that qualified is just the best answer here, what about:
```
let assemblyFormat = ` .... attr-dict `:` type($value) `,` `ptr` `` type($addr)`
```
?
https://github.com/llvm/llvm-project/pull/71285
More information about the Mlir-commits
mailing list