[Mlir-commits] [mlir] [MLIR][LLVM] Remove typed pointers from the LLVM dialect (PR #71285)

[Markus Böck]

================
@@ -445,7 +414,7 @@ def LLVM_StoreOp : LLVM_MemAccessOpBase<"store",
   let assemblyFormat = [{
     (`volatile` $volatile_^)? $value `,` $addr
     (`atomic` (`syncscope` `(` $syncscope^ `)`)? $ordering^)?
-    attr-dict `:` custom<StoreType>(type($value), type($addr))
+    attr-dict `:` type($value) `,` qualified(type($addr))
----------------
zero9178 wrote:

The problem is that not only `!llvm` is omitted, but the `ptr` prefix as well. It therefore prints just `<1>` when using an address space rather than either `ptr<1>` or `!llvm.ptr<1>`. This IMO makes it non-obvious what the type is, nor what the meaning of the `<1>` is supposed to be.

https://github.com/llvm/llvm-project/pull/71285