[Mlir-commits] [mlir] ec1a419 - [mlir][async] Fix missing dialect dependency in async-to-async-runtime

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 11 22:10:17 PDT 2022


Author: rkayaith
Date: 2022-10-12T01:10:08-04:00
New Revision: ec1a419143bda5bc20660e3325fd7843543503fa

URL: https://github.com/llvm/llvm-project/commit/ec1a419143bda5bc20660e3325fd7843543503fa
DIFF: https://github.com/llvm/llvm-project/commit/ec1a419143bda5bc20660e3325fd7843543503fa.diff

LOG: [mlir][async] Fix missing dialect dependency in async-to-async-runtime

The specific case I hit this was when lowering an `async.execute` that's
not inside a `func.func` op, e.g.:
```
llvm.func @foo() {
  %token = async.execute {
    async.yield
  }
  llvm.return
}
```

Reviewed By: bondhugula

Differential Revision: https://reviews.llvm.org/D135742

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Async/Passes.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Async/Passes.td b/mlir/include/mlir/Dialect/Async/Passes.td
index 76311b56302aa..16fb8626c0c0e 100644
--- a/mlir/include/mlir/Dialect/Async/Passes.td
+++ b/mlir/include/mlir/Dialect/Async/Passes.td
@@ -51,7 +51,7 @@ def AsyncToAsyncRuntime : Pass<"async-to-async-runtime", "ModuleOp"> {
            "Rewrite functions with blocking async.runtime.await as coroutines "
            "with async.runtime.await_and_resume.">,
   ];
-  let dependentDialects = ["async::AsyncDialect"];
+  let dependentDialects = ["async::AsyncDialect", "func::FuncDialect"];
 }
 
 def AsyncRuntimeRefCounting : Pass<"async-runtime-ref-counting"> {


        


More information about the Mlir-commits mailing list