[Mlir-commits] [mlir] 6d4baa7 - Apply clang-tidy fixes for performance-unnecessary-value-param in TileUsingInterface.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2022-10-12T05:03:45Z
New Revision: 6d4baa7442ccf7b87130b8b783164b8d9d1db005

URL: https://github.com/llvm/llvm-project/commit/6d4baa7442ccf7b87130b8b783164b8d9d1db005
DIFF: https://github.com/llvm/llvm-project/commit/6d4baa7442ccf7b87130b8b783164b8d9d1db005.diff

LOG: Apply clang-tidy fixes for performance-unnecessary-value-param in TileUsingInterface.cpp (NFC)

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
    mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
index 174b39ce8968..6cdef2512f60 100644
--- a/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
+++ b/mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
@@ -75,7 +75,7 @@ struct SCFTilingResult {
 /// `scf.for` for iterating over the tiles.
 FailureOr<SCFTilingResult> tileUsingSCFForOp(RewriterBase &rewriter,
                                              TilingInterface op,
-                                             SCFTilingOptions options);
+                                             const SCFTilingOptions &options);
 
 /// Options used to control tile + fuse.
 struct SCFTileAndFuseOptions {
@@ -127,9 +127,9 @@ struct SCFTileAndFuseResult {
 /// }
 /// ```
 FailureOr<SCFTileAndFuseResult>
-tileConsumerAndFuseProducerGreedilyUsingSCFForOp(RewriterBase &rewriter,
-                                                 TilingInterface consumer,
-                                                 SCFTileAndFuseOptions options);
+tileConsumerAndFuseProducerGreedilyUsingSCFForOp(
+    RewriterBase &rewriter, TilingInterface consumer,
+    const SCFTileAndFuseOptions &options);
 
 /// Method to lower an `op` that implements the `TilingInterface` to
 /// loops/scalars.

diff  --git a/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp b/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
index 2003b5e3cded..04704c89cdaa 100644
--- a/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
+++ b/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
@@ -265,7 +265,7 @@ updateDestinationOperandsForTiledOp(OpBuilder &builder,
 /// `TilingInterface` using `scf.for` to iterate over the tiles.
 FailureOr<scf::SCFTilingResult>
 mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter, TilingInterface op,
-                             scf::SCFTilingOptions options) {
+                             const scf::SCFTilingOptions &options) {
   OpBuilder::InsertionGuard guard(rewriter);
   rewriter.setInsertionPointAfter(op);
 
@@ -433,7 +433,7 @@ getUntiledProducerFromSliceSource(OpOperand *source,
 FailureOr<scf::SCFTileAndFuseResult>
 mlir::scf::tileConsumerAndFuseProducerGreedilyUsingSCFForOp(
     RewriterBase &rewriter, TilingInterface consumer,
-    scf::SCFTileAndFuseOptions options) {
+    const scf::SCFTileAndFuseOptions &options) {
   // This transformation is only valid for ops that return values (i.e. not
   // valid to use with operations that have memref operands).
   if (!consumer->getNumResults()) {