[Mlir-commits] [mlir] c4b7465 - [mlir] Fix a warning (NFC)

Kazu Hirata llvmlistbot at llvm.org
Mon Nov 7 09:54:15 PST 2022


Author: Kazu Hirata
Date: 2022-11-07T09:54:10-08:00
New Revision: c4b74658c7875cf2ac322956c2116c5fbea56158

URL: https://github.com/llvm/llvm-project/commit/c4b74658c7875cf2ac322956c2116c5fbea56158
DIFF: https://github.com/llvm/llvm-project/commit/c4b74658c7875cf2ac322956c2116c5fbea56158.diff

LOG: [mlir] Fix a warning (NFC)

This patch fixes:

  mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp:717:48:
  error: comparison of integers of different signs: 'int64_t' (aka
  'long') and 'uint64_t' (aka 'unsigned long')
  [-Werror,-Wsign-compare]

Added: 
    

Modified: 
    mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp b/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
index b0c88e161a50..6d6bd2625195 100644
--- a/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
+++ b/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
@@ -714,7 +714,7 @@ LogicalResult SortCooOp::verify() {
   auto checkDim = [&](Value v, uint64_t min, const char *message) {
     MemRefType tp = v.getType().cast<MemRefType>();
     int64_t dim = tp.getShape()[0];
-    if (dim != ShapedType::kDynamicSize && dim < min) {
+    if (dim != ShapedType::kDynamicSize && dim < (int64_t)min) {
       emitError(llvm::formatv("{0} got {1} < {2}", message, dim, min));
     }
   };


        


More information about the Mlir-commits mailing list