[llvm-dev] Consolidating copies of google/benchmark in the repo (Was: Proposal: introduce dependency on abseil when building benchmarks)
Chris Lattner via llvm-dev
llvm-dev at lists.llvm.org
Sun Oct 31 11:57:34 PDT 2021
> On Oct 29, 2021, at 7:00 AM, Michael Kruse <llvmdev at meinersbur.de> wrote:
> Am Mo., 25. Okt. 2021 um 10:18 Uhr schrieb Mircea Trofin <mtrofin at google.com>:
>> Circling back from https://reviews.llvm.org/D112012 - would having google/benchmark under a new `llvm-project/third-party` work, instead of `llvm-project/llvm/utils`? (rationale there, TL;DR; libcxx (and other runtimes) wants to detach itself from anything `llvm-project/llvm`)
> It would be only part of the solution as libcxx also depends on other
> things in llvm-project/llvm (CMake modules, lit, ...). If the goal is
> to make libcxx etc independent of the /llvm we should find out where
> those other dependencies go. Until then, IMHO there is nothing wrong
> to have libcxx depend on /llvm/utils/benchmark since it has /llvm is
> needed to build libc++ anyway.
I think it would make sense to move third party dependencies out of llvm-project/llvm for other reasons too, including layering (they can’t depend on other things in llvm) and license clarity.
More information about the llvm-dev