[llvm-dev] Consolidating copies of google/benchmark in the repo (Was: Proposal: introduce dependency on abseil when building benchmarks)

[via llvm-dev]

> > On Nov 1, 2021, at 12:15 PM, paul.robinson at sony.com wrote:
> >
> >> On 11/1/21 10:39 AM, Reid Kleckner via llvm-dev wrote:
> >>> On Sun, Oct 31, 2021 at 11:57 AM Chris Lattner via llvm-dev <llvm-
> >> dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> >>>
> >>>    I think it would make sense to move third party dependencies out of
> >> llvm-project/llvm for other reasons too, including layering (they can’t
> >> depend on other things in llvm) and license clarity.
> >>>
> >>>
> >>> +1, gtest & gmock come to mind.
> >>
> >> I'm in favor of this, but gtest currently has a dependency on
> LLVMSupport.
> >
> > According to the README we have local patches to support a few targets
> that
> > upstream gtest doesn't, and also allow some LLVM types (StringRef etc)
> to be
> > used in the printing features.
> 
> Huh ok.  Could that be handled by making them be a template or something?
> 
> -Chris

Without taking a deep look, that doesn't seem to be how gtest expects to be
customized.  The StringRef/SmallString stuff is in a header that's intended
to be modified by an installation, and consists of overloads that let the
gtest code DTRT when you do something like

    EXPECT_EQ(a, b) << c;

and 'c' is a StringRef or SmallString.

I haven't tried to look into the OS support.
--paulr