[llvm-dev] [cfe-dev] [RFC] Deprecate email code reviews in favor of Phabricator

[Christian Kühnel via llvm-dev]

It worked: the rule added the subscriber to [1] but not to [2]. So this way
we could send the email notifications from Phabricator.
Turning the rule off again to avoid user distractions...

[1] https://reviews.llvm.org/rG4ba8720f8844ae740e9424f90487ec308a22f40c
[2] https://reviews.llvm.org/rG93297e4bacd99f8c6711c136a4000c8526a7ea31
[3] https://reviews.llvm.org/H769


On Tue, May 4, 2021 at 5:27 PM Christian Kühnel <kuhnel at google.com> wrote:

> I think that should be fairly easy: I just created a Herald rule which
> adds the project "llvm-commits-test" as a subscriber to each commit:
> https://reviews.llvm.org/H773
>
> If we would add https://reviews.llvm.org/p/llvm-commits/ as subscriber,
> this would send emails to the mailing list instead...
>
> Best,
> Christian
>
>
> On Tue, May 4, 2021 at 5:10 PM via llvm-dev <llvm-dev at lists.llvm.org>
> wrote:
>
>> > > The commit email has a URL: link, e.g. this recent one (which has no
>> > > Dnnnnn review):
>> > >
>> > > URL:
>> https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3
>> > >
>> > > Does that take you to a different place than the rG link would?
>> > > Seems like they ought to go to the same place.
>> >
>> > That sends you to the GitHub commit for the change
>>
>> Doh!  Of course the commit message is from github not Phab, and
>> github doesn't know the Phab URL.  We'd have to have Phab send a
>> commit email instead, and insert the rG URL.  That's a bit more
>> complicated, yep.
>> --paulr
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210504/76ce3b02/attachment-0001.html>