<div dir="ltr"><div>It worked: the rule added the subscriber to [1] but not to [2]. So this way we could send the email notifications from Phabricator.</div><div>Turning the rule off again to avoid user distractions...</div><div><br></div><div>[1] <a href="https://reviews.llvm.org/rG4ba8720f8844ae740e9424f90487ec308a22f40c" target="_blank">https://reviews.llvm.org/rG4ba8720f8844ae740e9424f90487ec308a22f40c</a></div><div>[2] <a href="https://reviews.llvm.org/rG93297e4bacd99f8c6711c136a4000c8526a7ea31" target="_blank">https://reviews.llvm.org/rG93297e4bacd99f8c6711c136a4000c8526a7ea31</a></div><div>[3] <a href="https://reviews.llvm.org/H769" target="_blank">https://reviews.llvm.org/H769</a></div><div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 4, 2021 at 5:27 PM Christian Kühnel <<a href="mailto:kuhnel@google.com" target="_blank">kuhnel@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I think that should be fairly easy: I just created a Herald rule which adds the project "llvm-commits-test" as a subscriber to each commit: <div><a href="https://reviews.llvm.org/H773" target="_blank">https://reviews.llvm.org/H773</a><div><br></div><div>If we would add <a href="https://reviews.llvm.org/p/llvm-commits/" target="_blank">https://reviews.llvm.org/p/llvm-commits/</a> as subscriber, this would send emails to the mailing list instead...</div><div><div><div><br clear="all"><div><div dir="ltr"><div dir="ltr">Best,<div>Christian</div></div></div></div><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 4, 2021 at 5:10 PM via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> > The commit email has a URL: link, e.g. this recent one (which has no<br>
> > Dnnnnn review):<br>
> ><br>
> > URL: <a href="https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3</a><br>
> ><br>
> > Does that take you to a different place than the rG link would?<br>
> > Seems like they ought to go to the same place.<br>
> <br>
> That sends you to the GitHub commit for the change<br>
<br>
Doh!  Of course the commit message is from github not Phab, and<br>
github doesn't know the Phab URL.  We'd have to have Phab send a<br>
commit email instead, and insert the rG URL.  That's a bit more<br>
complicated, yep.<br>
--paulr<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
</blockquote></div></div>