[llvm-dev] Help with patch D101639

Francesco Bertolaccini via llvm-dev llvm-dev at lists.llvm.org
Sat May 1 00:42:38 PDT 2021


Hi everyone,
this is the first patch I've submitted to LLVM, and I'm not well
acquainted with the automated scripts that are run as pre-merge tests.

I've been able to solve the formatting related issues, but there are a
couple of tests that I'm not sure what to do about: clang-tidy warns
about missing header files, likely caused by the OCaml headers not being
present on the machine running pre-tests, and a suggested fix in case of
"unhelpful" clang-tidy warnings is to put the file into the ignorelist.
I'm not sure this is the right course of action, because obviously this
file has worked before without having to ignore it.

Also, the 'lit.lit::test-output-micro.py' completely stumps me, it
doesn't seem to be related to what I'm patching and I can't really
understand its result.

This is the link to phabricator for reference:
https://reviews.llvm.org/D101639

Thanks and best regards,
Francesco


More information about the llvm-dev mailing list