[llvm-dev] "[NFC]" Abuse
Hubert Tong via llvm-dev
llvm-dev at lists.llvm.org
Tue Jun 22 16:38:27 PDT 2021
On Fri, Jun 18, 2021 at 9:26 AM Mehdi AMINI via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Fri, Jun 18, 2021 at 4:07 AM Luke Drummond <luke.drummond at codeplay.com>
>> On Thu Jun 17, 2021 at 7:15 PM BST, Mehdi AMINI wrote:
>> > On Thu, Jun 17, 2021 at 10:15 AM David Blaikie via llvm-dev <
>> > llvm-dev at lists.llvm.org> wrote:
>> > > Got links to the reviews? Hard to discuss in the abstract.
>> > >
>> > > But generally, if it is intended to change observable behavior of the
>> > > program (if you have to modify a lit test, that's not NFC, if one
>> > > craft a test (that doesn't invoke UB, though that shouldn't be
>> > > through the command line interface, etc) that would need to be
>> > > when the patch is committed - then it's not NFC).
>> > >
>> > That's my litmus test: I see NFC is an indication that no test changes
>> > none are expected to be provided. The functional behavior of the
>> compiler is
>> > unchanged. I use NFC on API changes and refactoring when it fits this
>> > description.
>> I think this is a bit liberal as it ignores API users - unless I'm
>> misunderstanding your statement about what you mean by "API changes".
> Yes I am ignoring API users, I am on the same line as Nikita here.
> We don’t have stable APIs (other than the C one), so I for example I may
> change an API that was taking 3 bools to take now a struct parameter
> wrapping the 3 bools instead. I’ll tag it NFC.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev