[llvm-dev] LoopVectorizer: Should the cost-model be used for legalisation?
Sander De Smalen via llvm-dev
llvm-dev at lists.llvm.org
Fri Jun 11 08:10:50 PDT 2021
There was some discussion on these two patches:
* https://reviews.llvm.org/D102253 (Prevent vectorization with unsupported element types)
* https://reviews.llvm.org/D102437 (This patch is actually not really related, but one of my comments there sparked similar questions and discussion).
There are also two other patches related to legalisation:
https://reviews.llvm.org/D101916 (Avoid using scalable VFs if predicated instructions require scalarisation)
https://reviews.llvm.org/D102394 (Don't attempt to widen certain intrinsic calls for scalable vectors)
These patches together already cover a majority of the cases that explicitly require legalisation.
> On 11 Jun 2021, at 15:40, Sjoerd Meijer <Sjoerd.Meijer at arm.com> wrote:
> Hi Sander,
> Okay, that's fair enough, and thanks for explaining that. About the in-flight patches:
> > but we currently have a few patches in flight that have taken Option 1, and this led to some questions
> about the approach from both Florian and David Green.
> which patches are that exactly? (so that I can have a look at that for completeness).
> For the cost-model patch that I looked, it may look like Dave and I were arguing for Option 2, but I was trying to say that I still consider it Option1 for reasons I mentioned. So now I am curious if there are different opinions on the other patches.
> From: Sander De Smalen <Sander.DeSmalen at arm.com>
> Sent: 11 June 2021 15:25
> To: Sjoerd Meijer <Sjoerd.Meijer at arm.com>
> Cc: llvm-dev <llvm-dev at lists.llvm.org>
> Subject: Re: [llvm-dev] LoopVectorizer: Should the cost-model be used for legalisation?
> Hi Sjoerd,
> The question actually came up on three patches (including the one you refer to).
> The reason for focussing the attention to this is because this is a principled/design question of how we deal with legalisation, because if it is decided we don't want to add more `TTI->is<...>Legal()` to avoid vectorising, and instead implement this legalisation by returning InstructionCost::getInvalid(), then we'll want to change our in-flight patches to align with that approach. It also sets the precedent for future legalisation issues we'd need to fix.
> If for Option 1 we are to relax the restriction that the cost must be valid after the legaliser has said it is okay to vectorise with a given VF (thus allowing Invalid costs to avoid vectorisation with a given VF), then that will undermine the need for any legalisation functions whatsoever, because returning Invalid has the same effect. It is therefore a de facto choice for Option 2.
> That's the reason the specific patch you referred to uses some high-cost number but keeps the assertion in place. This patch is not really representative of the design question, it is purely a temporary workaround assuming we stick with Option 1. The alternative would have been to add proper legalisation interface, that we know would be removed again when we have full CodeGen coverage for <vscale x 1 x eltty> types.
> > On 11 Jun 2021, at 07:35, Sjoerd Meijer <Sjoerd.Meijer at arm.com> wrote:
> > Please correct me if I am wrong, but I thought this discussion was brought up by a temporarily workaround in the cost-model, working around current codegen limitations that needs fixing.
> > I am asking because Option 1 is what we currently have, and I don't see reasons to depart from this general idea, even if the cost-model can return Invalid due to a workaround that would hopefully disappear soon. That would mean the assert that the legalisation and cost-model are in sync would need to be skipped, and while that is not ideal, I don't see that as a big problem and I don't see it as a total departure from Option 1, especially if this is all temporarily.
> > And does this discussion disappear if the codegen issues are fixed? I don't know the scale of the problem/work, but is it not easier to fix that avoiding this cost-model vs. legalisation discussion?
> > From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Sander De Smalen via llvm-dev <llvm-dev at lists.llvm.org>
> > Sent: 10 June 2021 21:50
> > To: llvm-dev <llvm-dev at lists.llvm.org>
> > Subject: [llvm-dev] LoopVectorizer: Should the cost-model be used for legalisation?
> > Hi,
> > Last year we added the InstructionCost class which adds the ability to
> > represent that an operation cannot be costed, i.e. operations that cannot
> > be expanded by the code-generator will have an invalid cost.
> > We started using this information in the Loop Vectorizer for scalable
> > auto-vectorization. The LV has a legality- and a cost-model stage, which are
> > conceptually separate concepts with different purposes. But with the
> > introduction of having valid/invalid costs it's more inviting to use the
> > cost-model as 'legalisation', which leads us to the following question:
> > Should we be using the cost-model to do legalisation?
> > 'Legalisation' in this context means asking the question beforehand if the
> > code-generator can handle the IR emitted from the LV. Examples of
> > operations that need such legalisation are predicated divides (at least
> > until we can use the llvm.vp intrinsics), or intrinsic calls that have no
> > scalable-vector equivalent. For fixed-width vectors this legalisation issue
> > is mostly moot, since operations on fixed-width vectors can be scalarised.
> > For scalable vectors this is neither supported nor feasible .
> > This means there's the option to do one of two things:
> > [Option 1]
> > Add checks to the LV legalisation to see if scalable-vectorisation is
> > feasible. If so, assert the cost must be valid. Otherwise discard scalable
> > VFs as possible candidates.
> > * This has the benefit that the compiler can avoid
> > calculating/considering VPlans that we know cannot be costed.
> > * Legalisation and cost-model keep each other in check. If something
> > cannot be costed then either the cost-model or legalisation was
> > incomplete.
> > [Option 2]
> > Leave the question about legalisation to the CostModel, i.e. if the
> > CostModel says that <operation> for `VF=vscale x N` is Invalid, then avoid
> > selecting that VF.
> > * This has the benefit that we don't need to do work up-front to
> > discard scalable VFs, keeping the LV design simpler.
> > * This makes gaps in the cost-model more difficult to spot.
> > Note that it's not useful to combine Option 1 and Option 2, because having
> > two ways to choose from takes away the need to do legalisation beforehand,
> > and so that's basically a choice for Option 2.
> > Both approaches lead to the same end-result, but we currently have a few
> > patches in flight that have taken Option 1, and this led to some questions
> > about the approach from both Florian and David Green. So we're looking to
> > reach to a consensus and decision on what way to move forward.
> > I've tentatively added this as a topic to the agenda of the upcoming LLVM
> > SVE/Scalable Vector Sync-up meeting next Tuesday (June 15th, ) as an
> > opportunity to discuss this more freely if we can get enough people who
> > actively work on the LV together in that meeting (like Florian and David,
> > although please forward to anyone else who might have input on this).
> > Thanks,
> > Sander
> >  Expanding the vector operation into a scalarisation loop is currently
> > not supported. It could be done, but we have done extensive
> > experimentation with loops that handle each element of a scalable
> > vector sequentially, but this has never proved beneficial, even when
> > using special instructions to efficiently increment the predicate
> > vector. I doubt this will be any different for other scalable vector
> > architectures, because of the loop control overhead. Also the
> > insertion/extraction of elements from a scalable vector is unlikely to
> > be as cheap as for fixed-width vectors.
> >  https://docs.google.com/document/d/1UPH2Hzou5RgGT8XfO39OmVXKEibWPfdYLELSaHr3xzo/edit?usp=sharing
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
More information about the llvm-dev