[llvm-dev] Clang-12 fails build on MacOS

[Blumenthal, Uri - 0553 - MITLL via llvm-dev]

Thank you! All I correct to assume that this patch will run through the CI?

Regards,
Uri

> On Jul 19, 2021, at 16:25, Steven Wu <stevenwu at apple.com> wrote:
> 
>  I am not sure how that `add_custom_target` can help. Let's try run it during configuration time. Patch here: https://reviews.llvm.org/D106305
> 
> Steven
> 
> 
>>> On Jul 19, 2021, at 11:43 AM, Blumenthal, Uri - 0553 - MITLL <uri at ll.mit.edu> wrote:
>>> 
>>> I never intended to leave it at the broken state for MacPort but I am leaning towards finding a correct solution while I suggest some feasible workaround for you. 
>>>  
>>> Thank you!
>>> But it seems that adding a custom target in CMake via add_custom_target() would fix the MacPort version, while staying harmless on the other platforms? Or am I missing something…?
>>  
>> Can you propose a patch for that? I will happily review and commit it for you.
>>  
>> Let me converse with Ken, who has the honor of suggesting this fix, and reply. 
>>  
>> Offhand, it seems that somewhere (immediately) after this line 
>> https://github.com/llvm/llvm-project/blob/4c92e31dd0f1bd152eda883af20ff7fbcaa14945/compiler-rt/lib/builtins/CMakeLists.txt#L537
>> you’d need (something like)
>>  
>> add_custom_target(compiler-rt-asm ALL DEPENDS ${helper_asm})
>>  
>> Thanks!
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210719/ac79d7e1/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210719/ac79d7e1/attachment-0001.bin>