<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Thank you! All I correct to assume that this patch will run through the CI?<br><br><div dir="ltr">Regards,<div>Uri</div></div><div dir="ltr"><br><blockquote type="cite">On Jul 19, 2021, at 16:25, Steven Wu <stevenwu@apple.com> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">I am not sure how that `add_custom_target` can help. Let's try run it during configuration time. Patch here: <a href="https://reviews.llvm.org/D106305" class="">https://reviews.llvm.org/D106305</a><div class=""><br class=""></div><div class="">Steven</div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 19, 2021, at 11:43 AM, Blumenthal, Uri - 0553 - MITLL <<a href="mailto:uri@ll.mit.edu" class="">uri@ll.mit.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class=""><blockquote style="margin-top: 5pt; margin-bottom: 5pt;" class="" type="cite"><div class=""><div class=""><div style="margin-left: 0.5in;" class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">I never intended to leave it at the broken state for MacPort but I am leaning towards finding a correct solution while I suggest some feasible workaround for you.<span class="apple-converted-space"> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt;" class=""> </span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">Thank you!</span><o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">But it seems that adding a custom target in CMake via<span class="apple-converted-space"> </span></span><span style="font-size: 12pt; font-family: Courier; color: rgb(0, 112, 192);" class="">add_custom_target()</span><span class="apple-converted-space"><span style="font-size: 12pt; color: rgb(0, 112, 192);" class=""> </span></span><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">would fix the MacPort version, while staying harmless on the other platforms? Or am I missing something…?</span><o:p class=""></o:p></div></div></div></div></blockquote><div class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Can you propose a patch for that? I will happily review and commit it for you.<o:p class=""></o:p></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">Let me converse with Ken, who has the honor of suggesting this fix, and reply.<span class="Apple-converted-space"> </span><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">Offhand, it seems that somewhere (immediately) after this line<span class="Apple-converted-space"> </span><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class=""><a href="https://github.com/llvm/llvm-project/blob/4c92e31dd0f1bd152eda883af20ff7fbcaa14945/compiler-rt/lib/builtins/CMakeLists.txt#L537" style="color: blue; text-decoration: underline;" class="">https://github.com/llvm/llvm-project/blob/4c92e31dd0f1bd152eda883af20ff7fbcaa14945/compiler-rt/lib/builtins/CMakeLists.txt#L537</a><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">you’d need (something like)<o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0in 0.5in; font-size: 11pt; font-family: Calibri, sans-serif; background-color: white;" class=""><span style="font-family: Courier; color: rgb(0, 112, 192);" class="">add_custom_target(compiler-rt-asm ALL DEPENDS ${helper_asm})</span><span style="font-family: Courier;" class=""><o:p class=""></o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 12pt; color: rgb(0, 112, 192);" class="">Thanks!</span></div></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></body></html>