[llvm-dev] Pushing a patch for someone else

[Adrian McCarthy via llvm-dev]

And make sure the Differential Revision line has exactly one space between
the colon and the URL.

On Thu, Jan 28, 2021 at 8:01 AM via llvm-dev <llvm-dev at lists.llvm.org>
wrote:

>
>
> > -----Original Message-----
> > From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Paul C.
> > Anagnostopoulos via llvm-dev
> > Sent: Thursday, January 28, 2021 10:45 AM
> > To: llvm-dev at lists.llvm.org
> > Subject: [llvm-dev] Pushing a patch for someone else
> >
> > Could someone explain the best way to push a patch for someone else? I
> > don't use Arcanist, but add the Differential Revision line by hand.
> Please
> > include the method of downloading the person's patch to my machine.
>
> It's a bit of a manual process given that we don't use branches
> and a pull-request model as GitHub favors, but it's not hard.
> I don't think I've done this myself since the move to github so
> I might be missing a step, hopefully others will chime in to fix
> my mistakes.
>
> Assuming the patch is in a Phabricator review, there should be a
> "Download Raw Diff" link on the right-hand side at the top.  This,
> oddly enough, should download a diff file, which you can then apply
> to your working tree with "patch" or similar utility.
>
> What I do then is copy the summary into a text file, making sure
> the formatting looks reasonable.  You want to add two lines to it:
>
> Patch by <name of author>
>
> Differential Revision: https://reviews.llvm.org/Dxxxxx
>
> filling in the author and actual review number.  Make sure there's
> a blank line before the Differential Revision line.
>
> Then you commit this as usual, but add the --author option to
> provide (I think) the email address of the author.  (This might be
> redundant with the "Patch by" information, so the current practice
> might be to leave out "Patch by", not sure.)  And of course -F to
> specify the file where you put the commit message.
>
> Once it's committed, do the usual build/test/push.
>
> HTH,
> --paulr
>
> >
> > Needless to say, I've never done this before.
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://urldefense.com/v3/__https://lists.llvm.org/cgi-
> > bin/mailman/listinfo/llvm-
> > dev__;!!JmoZiZGBv3RvKRSx!tzZMDG77DN4la7BtUuhj60VZ9kl3C0IjWwiVXob43-
> > plBKeksKvrSBLMQZZzx0ZT0Q$
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210128/f10817b5/attachment.html>