[llvm-dev] Preparing BOLT for LLVM monorepo

[Wang, Phoebe via llvm-dev]

Hi Amir,

It makes sense to me. Thanks!

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Amir Aupov via llvm-dev
Sent: Tuesday, December 21, 2021 8:57 AM
To: llvm-dev at lists.llvm.org
Subject: Re: [llvm-dev] Preparing BOLT for LLVM monorepo

Hi Phoebe,

Thanks again for taking the time to look at the codebase. We've added your feedback to our upstreaming tracking issue on github: https://github.com/facebookincubator/BOLT/issues/248. We've started addressing the issues.

Regarding "not implemented” in Core/MCPlusBuilder.h: it's a design decision to prevent the use of non-implemented target-specific methods (these are virtual methods). Target-specific implementation goes to X86MCPlusBuilder and AArch64MCPlusBuilder. Some methods only make sense for specific targets, so we intend to keep llvm_unreachable statements in MCPlusBuilder.h.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211221/38ca54f1/attachment.html>