[llvm-dev] Preparing BOLT for LLVM monorepo

[Amir Aupov via llvm-dev]

Hi Phoebe,

Thanks again for taking the time to look at the codebase. We've added your
feedback to our upstreaming tracking issue on github:
https://github.com/facebookincubator/BOLT/issues/248. We've started
addressing the issues.

Regarding "not implemented” in Core/MCPlusBuilder.h: it's a design decision
to prevent the use of non-implemented target-specific methods (these are
virtual methods). Target-specific implementation goes to X86MCPlusBuilder
and AArch64MCPlusBuilder. Some methods only make sense for specific
targets, so we intend to keep llvm_unreachable statements in
MCPlusBuilder.h.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211220/cb017777/attachment.html>