[llvm-dev] How to submit a series of patches in a single review

[James Henderson via llvm-dev]

Just to add that if you put in your second patch summary "Depends on
DXXXXXX" where DXXXXXX is the identifier for the first patch, the patch
series is automatically linked together, so you don't need to manually
click on "Edit related revisions".

@David, I'd recommend you include this in your doc update.

As an aside, Phabricator is more powerful than a GitHub PR in this respect,
in that you can have a branching dependency tree, rather than having all
commits in a single linear list, should some patches themselves be somewhat
unrelated, but all depending on one more parent patches.

James

On Fri, 10 Dec 2021 at 12:14, David Spickett via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> I will write up something to go after
>
> https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> and post for review.
>
> On Fri, 10 Dec 2021 at 11:47, shaka via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > Thanks, Fraser. That sounds good. David just proposed the same solution.
> I will try.
> > But it would really help if there are any documents addressing this.
> >
> > ------------------ Original ------------------
> > From: Fraser Cormack <fraser at codeplay.com>
> > Date: Fri,Dec 10,2021 7:39 PM
> > To: 447521189 at qq.com <447521189 at qq.com>, llvm-dev at lists.llvm.org <
> llvm-dev at lists.llvm.org>
> > Subject: Re: [llvm-dev] How to submit a series of patches in a single
> review
> >
> > Hi Shaka,
> >
> > I just taught someone else how to do this morning!
> >
> > What I do first is option 2 to get 2 separate reviews, then navigate to
> > the web interface for 'B' and click "Edit Related Revisions" -> "Edit
> > Parent Revisions" -> <click A>.
> >
> > This creates a patch "stack" which is what you're after.
> >
> > I agree it's not very well documented: it took me a while to work out
> > what to do. Do people think we should add some documentation to this
> > effect?
> >
> > Thanks,
> > Fraser
> >
> > On Fri, 2021-12-10 at 19:28 +0800, shaka via llvm-dev wrote:
> > > Hi all,
> > >
> > > I'm new for community contribution and I wonder is there a way to
> > > submit patch series in a single review?
> > > For example I have 2 patches: A and B. B depends on A. How can I
> > > submit them together?
> > > 1. The Web interface (
> > >
> https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> > > ) seems doesn't allow uploading multiple patches.
> > > 2. I also tried the command line tool arc (
> > >
> https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
> > > ) by invoking `arc diff HEAD~` on each commit.
> > >     But these produce 2 seperate reviews and lose dependency.
> > >
> > > Any advice?
> > >
> > > Best regards,
> > > Shaka
> > > _______________________________________________
> > > LLVM Developers mailing list
> > > llvm-dev at lists.llvm.org
> > >
> > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> > >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211210/135efaed/attachment.html>