[llvm-dev] How to submit a series of patches in a single review

[David Spickett via llvm-dev]

I will write up something to go after
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
and post for review.

On Fri, 10 Dec 2021 at 11:47, shaka via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Thanks, Fraser. That sounds good. David just proposed the same solution. I will try.
> But it would really help if there are any documents addressing this.
>
> ------------------ Original ------------------
> From: Fraser Cormack <fraser at codeplay.com>
> Date: Fri,Dec 10,2021 7:39 PM
> To: 447521189 at qq.com <447521189 at qq.com>, llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>
> Subject: Re: [llvm-dev] How to submit a series of patches in a single review
>
> Hi Shaka,
>
> I just taught someone else how to do this morning!
>
> What I do first is option 2 to get 2 separate reviews, then navigate to
> the web interface for 'B' and click "Edit Related Revisions" -> "Edit
> Parent Revisions" -> <click A>.
>
> This creates a patch "stack" which is what you're after.
>
> I agree it's not very well documented: it took me a while to work out
> what to do. Do people think we should add some documentation to this
> effect?
>
> Thanks,
> Fraser
>
> On Fri, 2021-12-10 at 19:28 +0800, shaka via llvm-dev wrote:
> > Hi all,
> >
> > I'm new for community contribution and I wonder is there a way to
> > submit patch series in a single review?
> > For example I have 2 patches: A and B. B depends on A. How can I
> > submit them together?
> > 1. The Web interface (
> > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> > ) seems doesn't allow uploading multiple patches.
> > 2. I also tried the command line tool arc (
> > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
> > ) by invoking `arc diff HEAD~` on each commit.
> >     But these produce 2 seperate reviews and lose dependency.
> >
> > Any advice?
> >
> > Best regards,
> > Shaka
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> >
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev