[llvm-dev] clang-tidy makes review a pain

[Chris Tetreault via llvm-dev]

I agree that the clang-tidy reporting on your linked patch is quite egregious. I think that clang-tidy should only post feedback out of line. Ideally, it should only complain about actual violations of the llvm coding standards. I see nothing in the coding standards about requiring or preferring that stack locals being declared const if they can be.

Thanks,
                Christopher Tetreault

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Maxim Kazantsev via llvm-dev
Sent: Monday, April 19, 2021 2:43 AM
To: llvm-dev at lists.llvm.org
Subject: [EXT] [llvm-dev] clang-tidy makes review a pain

Hello everyone,

I started noticing that lately we've improved reporting from clang-tidy, pointing out at various formatting issues. However the more verbose it becomes, the more annoyed I feel about it. For example here:

https://reviews.llvm.org/D100721

It complains literally about every second line, inserting its comments straight into review. They take as much space as the actual code. Maybe it's just me, but it's really hard to me to understand what the patch is actually doing with so many inlined auto-generated comments. Maybe there is a button to hide them somewhere, but I failed to find it.

I understand what was the intention, and clang-tidy is a cool thing in general, but it's getting too intrusive. Does anyone else have the same problem as I do? If there's a lot of people whom it annoys, maybe we should think how to make it less invasive. Maybe it should put these comment when the patch gets approved, or something like this.

Thanks,
Max

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210419/241572bd/attachment.html>