[llvm-dev] I've gone and broken the build

[David Blaikie via llvm-dev]

On Sun, Sep 13, 2020 at 6:37 AM Paul C. Anagnostopoulos via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> Yes, you are correct. The second commit should have been an amend. I shall
> now endeavor to check each commit before I push it, to ensure there is
> exactly one.
>
> My concern was how to restart the build with the second commit, but
> apparently that is automatic or someone did it for me. Thanks to all for
> your patience!
>

Yeah, it's automatic - the bots keep rolling new revisions without need for
manual intervention. If you commit a breakage the best you can do is commit
the fix (if the forward fix is uncertain/complex, may be better to commit a
revert as a fix) as soon as possible (while being as careful as possible
not to introduce other issues) to reduce the window of breakage. (if you've
already committed the fix, as in your case, then there's nothing to do -
watch the bots, see that they go green again after picking up that change,
etc)

- Dave


>
>
> At 9/13/2020 09:24 AM, Hubert Tong wrote:
> >On Sun, Sep 13, 2020 at 8:12 AM Paul C. Anagnostopoulos via llvm-dev
> <<mailto:llvm-dev at lists.llvm.org>llvm-dev at lists.llvm.org> wrote:
> >At 9/12/2020 09:45 PM, Mehdi AMINI wrote:
> >>I'm on Windows. Is there a way to set up that hook?
> >>
> >>Ah sorry I'm not familiar enough with Windows, maybe someone else can
> chime in (and then we could update the doc as well).
> >
> >I'm standing by waiting to learn what to do about the broken build . . .
> >
> >The build was not (at the time when I looked yesterday) broken, so I was
> too confused to say more then.
> >
> >I think I understand the situation now: You did not intend to push either
> e8e3693ceaa1afe267f21d2ba8d9565ea8fe7c12 or
> 93b4f8538267e620de4a36e7cf0abc0d4f8d7c10, but the squashed version of the
> two. If that's the case, there's nothing to do now: the first left the tree
> in a bad state and one after fixed it.
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200913/9f0ed502/attachment-0001.html>