[llvm-dev] TableGen boolean literals: opinions, please

Paul C. Anagnostopoulos via llvm-dev llvm-dev at lists.llvm.org
Wed Oct 21 19:09:09 PDT 2020


I've always been a big fan of boolean literals like 'true' and 'false' instead of digits. It's just clearer that you're working with booleans.

At 10/21/2020 09:09 PM, Chris Lattner wrote:
>> On Oct 21, 2020, at 9:20 AM, Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> 
>> I need opinions from active TableGen users.
>> 
>> Does it make sense to add 'true' and 'false' boolean literals to TableGen, for use in assigning values to bit fields? If so, they would be TRUE and FALSE.
>> 
>> A search of all the TableGen files finds no use of TRUE or FALSE except in tests.
>
>You’re thinking about something like “bit x = TRUE;” instead of “bit x = 1;”?  Is there an advantage to that spelling?
>
>-Chris



More information about the llvm-dev mailing list