[llvm-dev] Chrome extension for tracking LLVM code review
Johannes Doerfert via llvm-dev
llvm-dev at lists.llvm.org
Tue Mar 31 22:32:28 PDT 2020
Hi River,
Disclaimer: I'm really not well versed in the JavaScript web browser
wold, so I might just do things wrong.
I tried Chromium before, all I get is: "No revisions require your
attention."
Maybe I have to wait for something to change?
I tried to manually build it with: `npm run-script build` but that
results in some weird (apparently often occurring) socket issue during
webpack. Stack overflow is full of descriptions of the same issues (=
same error) but always different causes. After a few attempt to make the
build work I basically gave up. Interestingly, I somehow generated a
build folder with a manifest file that I could load into firefox.
However, the popup says "Unhandled error: TypeError: resp.result.data[0]
is undefined" and the inspector shows all kinds of errors. Again, this
is probably because of my half-broken build.
FWIW, you don't have to fix this for me :)
Cheers,
Johannes
On 3/31/20 11:42 PM, River Riddle wrote:
> Hey Johannes,
>
> It should work for chromium out-of-the-box(in fact I just verified on my
> windows machine). For firefox I uploaded a simple API fix and
verified that
> it could run there as well. Chromium can use the same install link as
> chrome, for firefox I'll have to figure out how to upload an extension to
> the webstore.
>
> -- River
>
> On Tue, Mar 31, 2020 at 8:44 PM Johannes Doerfert <
> johannesdoerfert at gmail.com> wrote:
>
>> I'd be interested in using this but I have to wait until someone ports
>> this to firefox (or at least chromium).
>>
>> Thanks for sharing it though!
>>
>>
>> On 3/31/20 2:16 PM, River Riddle via llvm-dev wrote:
>>
>> For those interested I've uploaded to the chrome store to make installs
>> easier. An install link is now included on the repo.
>>
>> -- River
>>
>> On Mon, Mar 30, 2020, 1:44 PM River Riddle <riddleriver at gmail.com>
<riddleriver at gmail.com> wrote:
>>
>>
>> Hi all,
>>
>> Recently I've had some extra time on my hands, so I spent part of the
>> weekend coding up a simple chrome extension to monitor the status of
code
>> reviews on the LLVM phabricator instance. This extension is inspired by
>> some other review monitoring tools that I've used in the past. It allows
>> for monitoring revisions that a user needs to review, revisions by
the user
>> that need to be updated, and revisions by the user that are accepted and
>> ready to land. I'm posting here as this may be useful to others. I'm
also
>> happy to move this directly upstream if the community is interested.
>>
>> (disclaimer: I have limited experience in javascript so some things
could
>> definitely be improved).
>>
>> The code can be found here(along with an example screenshot of my own
>> review status): https://github.com/River707/llvm-review-monitor
>>
>> Thanks
>> -- River
>>
>>
>>
>> _______________________________________________
>> LLVM Developers mailing
listllvm-dev at lists.llvm.orghttps://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>>
>
More information about the llvm-dev
mailing list