[llvm-dev] RFC: Adding a staging branch (temporarily) to facilitate upstreaming
Keane, Erich via llvm-dev
llvm-dev at lists.llvm.org
Tue Jun 30 13:31:02 PDT 2020
If you click the ‘fork’ button on github more than once, it ends up giving your new fork a different name (llvm-project, llvm-project-1, etc). On the settings page of your fork, there is a way to rename the repository to the name of your choice.
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Chris Lattner via llvm-dev
Sent: Tuesday, June 30, 2020 1:29 PM
To: Chandler Carruth <chandlerc at google.com>
Cc: LLVM Dev <llvm-dev at lists.llvm.org>; Dmitri Gribenko <dmitrig at google.com>
Subject: Re: [llvm-dev] RFC: Adding a staging branch (temporarily) to facilitate upstreaming
On Jun 29, 2020, at 10:15 PM, Chandler Carruth via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
requests are contentious in LLVM.
Another alternative is to post a bulk Phabricator review and then "abandon" it. However, this has the disadvantage of not contributing the history (~30k commits).
Seeing the alternatives, if a closed pull-request would fit your use-case, then I'm not sure why you need the branch to actually live in the monorepo instead of in any fork (github.com/apple/llvm-project<http://github.com/apple/llvm-project> or another)? It seems publicly accessible the same way?
As I understand it, a key need is to explicitly contribute this to the LLVM project to make it unambiguous that it has been contributed and is completely available for folks not at Apple to iterate on the code and turn it into code-reviewable chunks.
So whatever happens needs to be quite explicit in its nature as a contribution. IMO, a branch of the repository definitely qualifies.
IMO, a pull request isn't as clear given that they haven't been used for contributions before. This is not a time to be innovative IMO. A branch as a staging location has been used many times over the history of the project though and seems nicely unambiguous in that regard.
I don’t have a opinion on this either way, but can git/GitHub maintain forks within the same organization? You could have llvm/llvm-project and llvm/llvm-project-apple-staging or something like that?
-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200630/dd55eeed/attachment.html>
More information about the llvm-dev
mailing list