[llvm-dev] Phabricator -> GitHub PRs?

Mehdi AMINI via llvm-dev llvm-dev at lists.llvm.org
Tue Jan 14 11:05:23 PST 2020

On Tue, Jan 14, 2020 at 10:46 AM David Greene via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> Renato Golin via llvm-dev <llvm-dev at lists.llvm.org> writes:
> > Honestly, the fact that I have to either user Arcanist or edit the
> > comments metadata by hand or use the UI to do a simple task is asking
> > a bit too much.
> This brings something else to mind for me.  Another advantage of GitHub
> is that there are many tools out there that work with it.  Not so much
> for Phab.  As an Emacs user, getting access to magit/forge's ability to
> interact with GitHub PRs would be amazing.

This is a reason I proposed using PR when we were looking to merge MLIR:
GitHub has an ecosystem of third-party tooling, for example we were relying
on this service: https://codecov.io/gh/tensorflow/mlir which provide
incremental code coverage annotation in GitHub pull-request.
That said there has been investment in pre-merge testing on our Phabricator
instance in the meantime, so I'm fairly happy about the improvement there
right now.

> > I think we need to move from "how apt is GitHub's PR UI in emulating
> > what Phab does" to "what do we really need from a review UI and how
> > simple it is the process for both contributors and reviewers".
> Absolutely.  Reviewing a patch series has always seemed a bit counter to
> LLVM's development philosophy of small, incremental changes.  I
> understand the need to provide context for large changes (I have posted
> mega-patches in Phab for that purpose), but the path to get to the large
> change has always been small, incremental changes.

There is a counter point to this: when folks doing a change needs a
refactoring, they are more likely to submit both in a single review in a
workflow that does not support patch series.

Even though I proposed to use GitHub PR a couple of months ago, the code
review experience seems not as good as Phabricator to me on some aspects
(on some other aspects, GitHub has been improving beyond our version of
Phabricator though, like proposing inline changes when reviewing).


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200114/d498611e/attachment.html>

More information about the llvm-dev mailing list