[llvm-dev] Policy question about Phabricator reviews

[Stefan Stipanovic via llvm-dev]

Hi Paul,

I've read "LLVM Code-Review Policies and Practices," but I remain unsure of
> a couple of things. Do I always wait for an actual "LGTM", or can people
> approve the patch for submission in other ways?

The patch is accepted through Phabricator with or without a message (the
message is usually LGTM or something similar)

 What happens when a patch is approved but then there are additional review
> comments? Should the patch be submitted as is, then a follow-up patch
> submitted, or should the additional review comments be incorporated first?

I think this depends on the patch. In most cases I'd incorporate the
changes first and if changes are not nits, probably wait for another
approval. Usually it is mentioned if you need to address comments in a
follow-up.

--Stefan

On Sun, Aug 16, 2020 at 4:29 PM Paul C. Anagnostopoulos via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> I've read "LLVM Code-Review Policies and Practices," but I remain unsure
> of a couple of things. Do I always wait for an actual "LGTM", or can people
> approve the patch for submission in other ways?
>
> What happens when a patch is approved but then there are additional review
> comments? Should the patch be submitted as is, then a follow-up patch
> submitted, or should the additional review comments be incorporated first?
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200816/406760e6/attachment.html>