[llvm-dev] Policy question about Phabricator reviews

Paul C. Anagnostopoulos via llvm-dev llvm-dev at lists.llvm.org
Sun Aug 16 07:26:04 PDT 2020

I've read "LLVM Code-Review Policies and Practices," but I remain unsure of a couple of things. Do I always wait for an actual "LGTM", or can people approve the patch for submission in other ways?

What happens when a patch is approved but then there are additional review comments? Should the patch be submitted as is, then a follow-up patch submitted, or should the additional review comments be incorporated first? 

More information about the llvm-dev mailing list