[llvm-dev] Make llvm-commits default cc on Phabricator

Robinson, Paul via llvm-dev llvm-dev at lists.llvm.org
Mon Apr 27 06:17:38 PDT 2020

If you set the repository to LLVM, then Phab will automatically cc llvm-commits.  I also thought there was something in Herald about looking at the path.  I see Herald adding cfe-commits and lldb-commits to some cross-project reviews, in a quick check.

I DO NOT want llvm-commits cc’d on *all* Phab reviews.  In particular, clang and lldb have their own -commits lists, and possibly others. llvm-commits is already very busy and adding other projects to it will not help reviewers.  llvm-commits should be for llvm proper, and other sub-projects that don’t have their own list (e.g., lld).

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Mehdi AMINI via llvm-dev
Sent: Sunday, April 26, 2020 1:42 AM
To: Alexandre Ganea <alexandre.ganea at ubisoft.com>
Cc: LLVM Dev <llvm-dev at lists.llvm.org>
Subject: Re: [llvm-dev] Make llvm-commits default cc on Phabricator


I thought we already had a rule subscribing llvm-commits, but I can't find it?
I created a new here: https://reviews.llvm.org/H615 and it worked immediately with Arc but is actually didn't originally when uploading a diff on the web interface.
I had to tweak the regex many times to get it to match, it seems like there are whitespace in front of the path when you don't use `arc`, I settled with @^\s*/llvm/@ right now.


On Fri, Apr 24, 2020 at 11:42 AM Alexandre Ganea via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:

I sometime forget to set the “Repository” when uploading a patch on Phabricator, and that prevents from adding llvm-commits as a subscriber.
[cid:image001.png at 01D61C73.B63F3220]

Would it make sense to set ‘LLVM Github Monorepo’ as a default? Or subscribe ‘llvm-commits’ automatically when creating a patch?


LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200427/238fd62c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 3097 bytes
Desc: image001.png
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200427/238fd62c/attachment-0001.png>

More information about the llvm-dev mailing list