[llvm-dev] [RFC] Improving FileCheck

[Alexandre Isoard via llvm-dev]

Just to add to this, I have sometimes used a semi-column instead of a
column and wondered why it didn't work. Is that included in gotcha A?

On Fri, Apr 17, 2020 at 3:04 PM Joel E. Denny via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Mon, Apr 13, 2020 at 1:16 PM Jon Roelofs via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> As an update, after lots of fixes from a number of different people
>> (thanks everyone!), the current list of false-positives on `ninja
>> check-llvm` for the more stringent Gotcha A diagnostic is:
>>
>>   LLVM :: Analysis/CostModel/X86/vselect-cost.ll
>>   LLVM :: CodeGen/AMDGPU/GlobalISel/smrd.ll
>>   LLVM :: CodeGen/AMDGPU/fp_to_uint.ll
>>   LLVM :: CodeGen/AMDGPU/global-constant.ll
>>   LLVM :: CodeGen/AMDGPU/merge-tbuffer.mir
>>   LLVM :: CodeGen/AMDGPU/smrd.ll
>>   LLVM :: CodeGen/AMDGPU/unhandled-loop-condition-assertion.ll
>>   LLVM :: CodeGen/ARM/build-attributes.ll
>>   LLVM :: CodeGen/ARM/float-helpers.s
>>   LLVM :: CodeGen/ARM/select-imm.ll
>>   LLVM :: CodeGen/ARM/struct_byval_arm_t1_t2.ll
>>   LLVM :: CodeGen/Mips/cconv/arguments-float.ll
>>   LLVM :: CodeGen/Mips/cconv/arguments-hard-float-varargs.ll
>>   LLVM :: CodeGen/Mips/cconv/arguments-hard-float.ll
>>   LLVM :: CodeGen/Mips/cconv/arguments-varargs.ll
>>   LLVM :: CodeGen/Mips/cconv/arguments.ll
>>   LLVM :: CodeGen/Mips/cconv/return-hard-fp128.ll
>>   LLVM :: CodeGen/Mips/cconv/return-hard-struct-f128.ll
>>   LLVM :: CodeGen/Mips/ci2.ll
>>   LLVM :: CodeGen/Mips/countleading.ll
>>   LLVM :: CodeGen/Mips/divrem.ll
>>   LLVM :: CodeGen/Mips/dynamic-stack-realignment.ll
>>   LLVM :: CodeGen/Mips/inlineasm-operand-code.ll
>>   LLVM :: CodeGen/Mips/mips64muldiv.ll
>>   LLVM :: CodeGen/PowerPC/ppc64-crsave.mir
>>   LLVM :: CodeGen/X86/avx-cast.ll
>>   LLVM :: CodeGen/X86/fp-intrinsics.ll
>>   LLVM :: CodeGen/X86/splat-for-size.ll
>>   LLVM :: CodeGen/X86/sse-scalar-fp-arith.ll
>>   LLVM :: CodeGen/X86/vec_shift6.ll
>>   LLVM :: CodeGen/X86/vector-compare-combines.ll
>>   LLVM :: CodeGen/X86/vector-narrow-binop.ll
>>   LLVM :: DebugInfo/COFF/vframe-fpo.ll
>>   LLVM :: DebugInfo/X86/debug-info-static-member.ll
>>   LLVM :: FileCheck/check-empty-tag.txt
>>   LLVM :: FileCheck/dump-input-annotations.txt
>>   LLVM :: FileCheck/no-multi-suffixes.txt
>>   LLVM :: FileCheck/var-scope.txt
>>   LLVM :: MC/AsmParser/expr-shr.s
>>   LLVM :: MC/Mips/relocation-n64.s
>>   LLVM :: MC/Mips/relocation.s
>>   LLVM :: MC/RISCV/compressed-relocations.s
>>   LLVM :: MC/RISCV/relocations.s
>>   LLVM :: MC/RISCV/rv32b-aliases-valid.s
>>   LLVM :: MC/RISCV/rv64b-aliases-valid.s
>>   LLVM :: MC/RISCV/rva-aliases-valid.s
>>   LLVM :: MC/RISCV/rvi-aliases-valid.s
>>   LLVM :: Transforms/InstCombine/double-float-shrink-2.ll
>>   LLVM :: Transforms/LoopFusion/cannot_fuse.ll
>>   LLVM :: tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
>>   LLVM :: tools/llvm-readobj/ELF/RISCV/section-types.test
>>   LLVM :: tools/llvm-readobj/ELF/section-types.test
>>   LLVM :: tools/llvm-readobj/ELF/symbol-binding.test
>>
>> All of these are variants in some form or another of comments that
>> contain the check prefix, but which are intentionally not actual CHECK
>> lines.
>>
>
> Thanks for working on this.  That report makes me think the diagnostic is
> going to be frustrating.  What do you think?
>
> Joel
>
>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>


-- 
*Alexandre Isoard*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200418/b0229bb2/attachment.html>