<div dir="ltr">Just to add to this, I have sometimes used a semi-column instead of a column and wondered why it didn't work. Is that included in gotcha A?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 17, 2020 at 3:04 PM Joel E. Denny via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 13, 2020 at 1:16 PM Jon Roelofs via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>As an update, after lots of fixes from a number of different people (thanks everyone!), the current list of false-positives on `ninja check-llvm` for the more stringent Gotcha A diagnostic is:<br><br> LLVM :: Analysis/CostModel/X86/vselect-cost.ll<br> LLVM :: CodeGen/AMDGPU/GlobalISel/smrd.ll<br> LLVM :: CodeGen/AMDGPU/fp_to_uint.ll<br> LLVM :: CodeGen/AMDGPU/global-constant.ll<br> LLVM :: CodeGen/AMDGPU/merge-tbuffer.mir<br> LLVM :: CodeGen/AMDGPU/smrd.ll<br> LLVM :: CodeGen/AMDGPU/unhandled-loop-condition-assertion.ll<br> LLVM :: CodeGen/ARM/build-attributes.ll<br> LLVM :: CodeGen/ARM/float-helpers.s<br> LLVM :: CodeGen/ARM/select-imm.ll<br> LLVM :: CodeGen/ARM/struct_byval_arm_t1_t2.ll<br> LLVM :: CodeGen/Mips/cconv/arguments-float.ll<br> LLVM :: CodeGen/Mips/cconv/arguments-hard-float-varargs.ll<br> LLVM :: CodeGen/Mips/cconv/arguments-hard-float.ll<br> LLVM :: CodeGen/Mips/cconv/arguments-varargs.ll<br> LLVM :: CodeGen/Mips/cconv/arguments.ll<br> LLVM :: CodeGen/Mips/cconv/return-hard-fp128.ll<br> LLVM :: CodeGen/Mips/cconv/return-hard-struct-f128.ll<br> LLVM :: CodeGen/Mips/ci2.ll<br> LLVM :: CodeGen/Mips/countleading.ll<br> LLVM :: CodeGen/Mips/divrem.ll<br> LLVM :: CodeGen/Mips/dynamic-stack-realignment.ll<br> LLVM :: CodeGen/Mips/inlineasm-operand-code.ll<br> LLVM :: CodeGen/Mips/mips64muldiv.ll<br> LLVM :: CodeGen/PowerPC/ppc64-crsave.mir<br> LLVM :: CodeGen/X86/avx-cast.ll<br> LLVM :: CodeGen/X86/fp-intrinsics.ll<br> LLVM :: CodeGen/X86/splat-for-size.ll<br> LLVM :: CodeGen/X86/sse-scalar-fp-arith.ll<br> LLVM :: CodeGen/X86/vec_shift6.ll<br> LLVM :: CodeGen/X86/vector-compare-combines.ll<br> LLVM :: CodeGen/X86/vector-narrow-binop.ll<br> LLVM :: DebugInfo/COFF/vframe-fpo.ll<br> LLVM :: DebugInfo/X86/debug-info-static-member.ll<br> LLVM :: FileCheck/check-empty-tag.txt<br> LLVM :: FileCheck/dump-input-annotations.txt<br> LLVM :: FileCheck/no-multi-suffixes.txt<br> LLVM :: FileCheck/var-scope.txt<br> LLVM :: MC/AsmParser/expr-shr.s<br> LLVM :: MC/Mips/relocation-n64.s<br> LLVM :: MC/Mips/relocation.s<br> LLVM :: MC/RISCV/compressed-relocations.s<br> LLVM :: MC/RISCV/relocations.s<br> LLVM :: MC/RISCV/rv32b-aliases-valid.s<br> LLVM :: MC/RISCV/rv64b-aliases-valid.s<br> LLVM :: MC/RISCV/rva-aliases-valid.s<br> LLVM :: MC/RISCV/rvi-aliases-valid.s<br> LLVM :: Transforms/InstCombine/double-float-shrink-2.ll<br> LLVM :: Transforms/LoopFusion/cannot_fuse.ll<br> LLVM :: tools/llvm-objdump/ELF/dynamic-section-machine-specific.test<br> LLVM :: tools/llvm-readobj/ELF/RISCV/section-types.test<br> LLVM :: tools/llvm-readobj/ELF/section-types.test<br> LLVM :: tools/llvm-readobj/ELF/symbol-binding.test</div><div><br></div><div>All of these are variants in some form or another of comments that contain the check prefix, but which are intentionally not actual CHECK lines.</div></div></blockquote><div><br></div><div>Thanks for working on this. That report makes me think the diagnostic is going to be frustrating. What do you think?</div><div><br></div></div><div class="gmail_quote">Joel<br></div><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><b>Alexandre Isoard</b><br></div></div>