[llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame

[James Henderson via llvm-dev]

I tend to use git blame via the Github UI. This provides a single-click
button to go to the commit before the commit in question, so it'll add an
extra click to go back in time (and corresponding page reload time), which
is less than ideal, but isn't the worst thing in the world. I think I've
probably only used git blame directly in LLVM on single-figure occasions,
and nearly always found it easier to then go to github for one reason or
another, so much so that I don't remember how long it's been since I last
actually used the command line to do it. There are numerous cases I run
into where the code has slightly changed due to a new API parameter, a
variable rename, a re-ordering or refactoring of code or whatever, so one
extra commit I need to ignore is not a big deal.

James

On Wed, 24 Jul 2019 at 10:03, Alex Bradbury via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Tue, 23 Jul 2019 at 16:31, James Y Knight via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > As a very frequent explorer of history, I really don't think this is
> > as big an issue as it may seem. Even absent refactorings, you often
> > run into the "wrong" commit when looking at blame (e.g., someone just
> > added a comma rather than actually changing the code you care about),
> > and have to look past that, to another previous commit.
> >
> > Any interactive blame tool ought to have an easy way to do this. For
> > example, in emacs's annotation mode (which is what I use), you just
> > press 'a' with the cursor on the line in question to re-annotate at
> > the commit previous to that.
>
> This matches my experience too, and I'm also frequently exploring
> blame history. Internal APIs get adjusted pretty frequently in LLVM so
> I it's incredibly common for any of my blame digging to have to look
> through intermediate cleanup commits. Given this experience, I'm a bit
> puzzled on why blame history is brought up as a concern so frequently,
> but possibly people are using blame in a different way?
>
> Best,
>
> Alex
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190724/adb753ae/attachment.html>