[llvm-dev] [RFC] Documentation clarification: Phabricator, not the lists is the main entry point for new patches

Doerfert, Johannes via llvm-dev llvm-dev at lists.llvm.org
Thu Jul 11 09:45:17 PDT 2019


+1 for clarity as it is friendlier for outsiders

________________________________________
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Roman Lebedev via llvm-dev <llvm-dev at lists.llvm.org>
Sent: Wednesday, June 19, 2019 09:29
To: llvm-dev at lists.llvm.org
Subject: [llvm-dev] [RFC] Documentation clarification: Phabricator, not the lists is the main entry point for new patches

The current documentation talks about both the Phabricator review, and review
as mail replies on -commits lists. It also talks about submitting
patches to lists,
with the subtext that it may be friendlier for outsiders.

It is true that Phabricator has some entry threshold, larger than
github, or maillists,
so the attempt is not unwarranted. But from what i can tell, 99.9% patches go
via Phabricator. There is a large chance that such a mail-only patch
will simply be
overlooked, ignored, or the very first reply will be "Please post the patch to
Phabricator".

Both of these cases i would call counter-welcoming.
I don't think that is what we want?

I propose to fix the docs to specify that all new patches should go
via Phabricator, not lists:
https://reviews.llvm.org/D63488

Roman.
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


More information about the llvm-dev mailing list