[llvm-dev] Hexagon automatically generated code - proposed change

Richard Trieu via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 31 13:59:48 PST 2019


The file has been moved in r352802.

On Thu, Jan 31, 2019 at 6:21 AM Krzysztof Parzyszek <kparzysz at codeaurora.org>
wrote:

> Hi Richard,
> I'm off work for a few days, I can do it when I come back.  In the
> meantime, if you feel so inclined, feel free to make that change.
>
> Thanks!
> -Krzysztof
>
>
> On 1/30/2019 11:05 PM, Richard Trieu wrote:
> > Krzysztof,
> >
> > lib/Target/Hexagon/HexagonDepDecoders.h is marked as generated code and
> > I should consult you, as code owner, before changing.  As this file is
> > not a stand-alone header (does not compile alone, no header guards, is
> > included in the middle of other files) it should not have the .h
> > extension.  I propose that this file be renamed to have .inc extension
> > to be consistent with the coding standard.
> >
> > Richard
> >
> > <
> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
>
> >       Virus-free. www.avg.com
> > <
> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
>
> >
> >
> > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190131/79ef2d24/attachment.html>


More information about the llvm-dev mailing list