<div dir="ltr"><div dir="ltr">The file has been moved in r352802.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 31, 2019 at 6:21 AM Krzysztof Parzyszek <<a href="mailto:kparzysz@codeaurora.org">kparzysz@codeaurora.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Richard,<br>
I'm off work for a few days, I can do it when I come back.  In the <br>
meantime, if you feel so inclined, feel free to make that change.<br>
<br>
Thanks!<br>
-Krzysztof<br>
<br>
<br>
On 1/30/2019 11:05 PM, Richard Trieu wrote:<br>
> Krzysztof,<br>
> <br>
> lib/Target/Hexagon/HexagonDepDecoders.h is marked as generated code and <br>
> I should consult you, as code owner, before changing.  As this file is <br>
> not a stand-alone header (does not compile alone, no header guards, is <br>
> included in the middle of other files) it should not have the .h <br>
> extension.  I propose that this file be renamed to have .inc extension <br>
> to be consistent with the coding standard.<br>
> <br>
> Richard<br>
> <br>
> <<a href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" rel="noreferrer" target="_blank">http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient</a>> <br>
>       Virus-free. <a href="http://www.avg.com" rel="noreferrer" target="_blank">www.avg.com</a> <br>
> <<a href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" rel="noreferrer" target="_blank">http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient</a>> <br>
> <br>
> <br>
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2><br>
<br>
</blockquote></div>