[llvm-dev] __clear_cache / clear_cache.c

[Jay K via llvm-dev]

projects/compiler-rt/lib/builtins/clear_cache.c

I suggest two small changes here.

1. Mark it however required to avoid inlining, i.e. for the x86/amd64 case.
Control transfer is required. I realize it is likely anyway, you aren't likely
to "fall from" the caller into the code.

2. #elif defined(_WIN32) && (defined(__arm__) || defined(__aarch64__))
be changed to just:
#elif defined(_WIN32)

since Win32 hypothetically/historically runs on more than just x86/amd64/arm/arm64, and
FlushInstructionCache has been and presumably will remain omnipresent.

 - Jay


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180415/83b0bac5/attachment.html>